diff options
| author | Sami Kerola | 2013-06-16 20:53:42 +0200 |
|---|---|---|
| committer | Karel Zak | 2013-07-01 11:07:19 +0200 |
| commit | 665b3c85721e8653bef0c41d0f455e1aebbd2208 (patch) | |
| tree | ff08ef8f2daaa60e0d39da88ad3a5152f02fbc69 /sys-utils/renice.c | |
| parent | findmnt: test for fstype/options/maj:min before source and target (diff) | |
| download | kernel-qcow2-util-linux-665b3c85721e8653bef0c41d0f455e1aebbd2208.tar.gz kernel-qcow2-util-linux-665b3c85721e8653bef0c41d0f455e1aebbd2208.tar.xz kernel-qcow2-util-linux-665b3c85721e8653bef0c41d0f455e1aebbd2208.zip | |
renice: exit with non-zero value when arguments cause warnings
This commit also fixes potential error counter wrap, which theoretically
could make command to exit with a success when it internally failed just
correct amount of times.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'sys-utils/renice.c')
| -rw-r--r-- | sys-utils/renice.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sys-utils/renice.c b/sys-utils/renice.c index 50b16422b..c0378e1a5 100644 --- a/sys-utils/renice.c +++ b/sys-utils/renice.c @@ -138,6 +138,7 @@ main(int argc, char **argv) if (pwd == NULL) { warnx(_("unknown user %s"), *argv); + errs = 1; continue; } who = pwd->pw_uid; @@ -145,10 +146,11 @@ main(int argc, char **argv) who = strtol(*argv, &endptr, 10); if (who < 0 || *endptr) { warnx(_("bad value %s"), *argv); + errs = 1; continue; } } - errs += donice(which, who, prio); + errs |= donice(which, who, prio); } return errs != 0 ? EXIT_FAILURE : EXIT_SUCCESS; } |