diff options
| author | Sami Kerola | 2018-05-03 23:57:58 +0200 |
|---|---|---|
| committer | Karel Zak | 2018-05-10 11:25:05 +0200 |
| commit | 8fd27bec0c5cb5ade55cf0a9d606aa1dbeeed95f (patch) | |
| tree | 6958bac917532661a1f6528219a56a9a16218611 /sys-utils/zramctl.c | |
| parent | lib/canonicalize: fix truncation warning (diff) | |
| download | kernel-qcow2-util-linux-8fd27bec0c5cb5ade55cf0a9d606aa1dbeeed95f.tar.gz kernel-qcow2-util-linux-8fd27bec0c5cb5ade55cf0a9d606aa1dbeeed95f.tar.xz kernel-qcow2-util-linux-8fd27bec0c5cb5ade55cf0a9d606aa1dbeeed95f.zip | |
zramctl: fix truncation warning
sys-utils/zramctl.c: In function ‘zram_get_sysfs’:
sys-utils/zramctl.c:220:52: warning: ‘%s’ directive output may be truncated
writing up to 4095 bytes into a region of size 27 [-Wformat-truncation=]
snprintf(z->devname, sizeof(z->devname), "/dev/%s", name);
As an additional good thing zramctl will no longer allocate 4096 bytes from
stack when just 23 bytes is enough.
[kzak@redhat.com: - use macro rather than hardcoded string for the path]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'sys-utils/zramctl.c')
| -rw-r--r-- | sys-utils/zramctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys-utils/zramctl.c b/sys-utils/zramctl.c index 8da7b2ddb..bedb0a042 100644 --- a/sys-utils/zramctl.c +++ b/sys-utils/zramctl.c @@ -215,9 +215,9 @@ static struct sysfs_cxt *zram_get_sysfs(struct zram *z) return NULL; if (*z->devname != '/') { /* canonicalize the device name according to /sys */ - char name[PATH_MAX]; + char name[sizeof(z->devname) - sizeof(_PATH_DEV)]; if (sysfs_get_devname(&z->sysfs, name, sizeof(name))) - snprintf(z->devname, sizeof(z->devname), "/dev/%s", name); + snprintf(z->devname, sizeof(z->devname), _PATH_DEV "%s", name); } } |