diff options
| author | Karel Zak | 2019-05-28 11:58:51 +0200 |
|---|---|---|
| committer | Karel Zak | 2019-05-28 11:58:51 +0200 |
| commit | fe2e38f3b15f397aa1edc768237e9408c8a688f9 (patch) | |
| tree | 5b45c69ff208e6d55e800bb5d1b9504b4f4246a6 /sys-utils | |
| parent | mesg: avoid 'ttyname failed: Success' message (diff) | |
| download | kernel-qcow2-util-linux-fe2e38f3b15f397aa1edc768237e9408c8a688f9.tar.gz kernel-qcow2-util-linux-fe2e38f3b15f397aa1edc768237e9408c8a688f9.tar.xz kernel-qcow2-util-linux-fe2e38f3b15f397aa1edc768237e9408c8a688f9.zip | |
lscpu: make lookup() use more consistent [coverity scan]
We usually check lookup() return value. Let's do it in this case too.
It seems static analyzers will be happy with consistent code.
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'sys-utils')
| -rw-r--r-- | sys-utils/lscpu.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sys-utils/lscpu.c b/sys-utils/lscpu.c index f64d81836..48b376458 100644 --- a/sys-utils/lscpu.c +++ b/sys-utils/lscpu.c @@ -626,8 +626,10 @@ read_basicinfo(struct lscpu_desc *desc, struct lscpu_modifier *mod) read_physical_info_powerpc(desc); if ((fp = ul_path_fopen(desc->procfs, "r", "sysinfo"))) { - while (fgets(buf, sizeof(buf), fp) != NULL && !desc->machinetype) - lookup(buf, "Type", &desc->machinetype); + while (fgets(buf, sizeof(buf), fp) != NULL) { + if (lookup(buf, "Type", &desc->machinetype)) + break; + } fclose(fp); } |