diff options
| author | Ruediger Meier | 2016-03-05 18:51:59 +0100 |
|---|---|---|
| committer | Ruediger Meier | 2016-03-07 23:34:24 +0100 |
| commit | 7e604f3c804a5718b1c591eb32043d140f052803 (patch) | |
| tree | 4774fa8814528798eb9971a715bff7315af82597 /tests/expected/eject | |
| parent | tests: cramfs, fix root group (diff) | |
| download | kernel-qcow2-util-linux-7e604f3c804a5718b1c591eb32043d140f052803.tar.gz kernel-qcow2-util-linux-7e604f3c804a5718b1c591eb32043d140f052803.tar.xz kernel-qcow2-util-linux-7e604f3c804a5718b1c591eb32043d140f052803.zip | |
tests: don't skip case "output undefined"
Treat missing expected files as empty and let the test fail if
there is non-empty output.
Expected output may be missing in these cases:
1. forgot to commit the file after changing/adding a (sub)test
2. a bug in a test where we do tricks with TS_EXPECTED
3. and most notable if ts_die() is called before a subtest is
initialized, e.g. in ts_scsi_debug_init()
I always wondered why we don't treat this as FAILED. Now we do
so, ts_finalize and ts_gen_diff looks much cleaner now.
The change discovers that tests with subtest were ignoring the
"non-sub" expected files which had to be fixed. BTW we removed
any zero sized files.
Moreover now we respect diff's return value. In past all test
succeeded when diff was not able to write to diffdir, e.g. when
running tests as normal user after they run as root.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Diffstat (limited to 'tests/expected/eject')
| -rw-r--r-- | tests/expected/eject/umount | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/tests/expected/eject/umount b/tests/expected/eject/umount deleted file mode 100644 index e69de29bb..000000000 --- a/tests/expected/eject/umount +++ /dev/null |