diff options
| author | Sami Kerola | 2017-02-11 21:23:26 +0100 |
|---|---|---|
| committer | Karel Zak | 2017-02-20 12:58:49 +0100 |
| commit | 87918040658f2fa9b1bf78f1f8f4f5c065a2e3a3 (patch) | |
| tree | 513541cfa347d7fc66e50137603489cb195c86de /text-utils/column.c | |
| parent | cfdisk: avoid use of VLA in combination with sizeof() [smatch scan] (diff) | |
| download | kernel-qcow2-util-linux-87918040658f2fa9b1bf78f1f8f4f5c065a2e3a3.tar.gz kernel-qcow2-util-linux-87918040658f2fa9b1bf78f1f8f4f5c065a2e3a3.tar.xz kernel-qcow2-util-linux-87918040658f2fa9b1bf78f1f8f4f5c065a2e3a3.zip | |
misc: do not use plain 0 as NULL [smatch scan]
text-utils/tailf.c:69:21: warning: Using plain integer as NULL pointer
Since many 'struct option' has used zero as NULL make them more readable in
same go by reindenting, and using named argument requirements.
Reference: https://lwn.net/Articles/93577/
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'text-utils/column.c')
| -rw-r--r-- | text-utils/column.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/text-utils/column.c b/text-utils/column.c index 2eb47a3ea..deeea855e 100644 --- a/text-utils/column.c +++ b/text-utils/column.c @@ -152,15 +152,15 @@ int main(int argc, char **argv) static const struct option longopts[] = { - { "columns", 1, 0, 'c' }, /* deprecated */ - { "fillrows", 0, 0, 'x' }, - { "help", 0, 0, 'h' }, - { "output-separator", 1, 0, 'o' }, - { "output-width", 1, 0, 'c' }, - { "separator", 1, 0, 's' }, - { "table", 0, 0, 't' }, - { "version", 0, 0, 'V' }, - { NULL, 0, 0, 0 }, + { "columns", required_argument, NULL, 'c' }, /* deprecated */ + { "fillrows", no_argument, NULL, 'x' }, + { "help", no_argument, NULL, 'h' }, + { "output-separator", required_argument, NULL, 'o' }, + { "output-width", required_argument, NULL, 'c' }, + { "separator", required_argument, NULL, 's' }, + { "table", no_argument, NULL, 't' }, + { "version", no_argument, NULL, 'V' }, + { NULL, 0, NULL, 0 }, }; setlocale(LC_ALL, ""); |