diff options
| author | Sami Kerola | 2017-05-16 10:18:24 +0200 |
|---|---|---|
| committer | Karel Zak | 2017-06-14 11:48:22 +0200 |
| commit | b1557fe98120132e6671924af4ed69f4e21d3de4 (patch) | |
| tree | 5b7a0e689fd4a09288f57c3a8eb4f24075ca65a3 /text-utils/ul.c | |
| parent | libblkid: fix gcc-7 warning -Wint-in-bool-context (diff) | |
| download | kernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.tar.gz kernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.tar.xz kernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.zip | |
misc: fix ggc-7 fallthrough warnings
(Original patch and commit message edited by Rudi.)
gcc-7 adds -Wimplicit-fallthrough=3 to our default flag -Wextra.
This warning can be silenced by using comment /* fallthrough */
which is also recognized by other tools like coverity. There are
also other valid comments (see man gcc-7) but we consolidate this
style now.
We could have also used __attribute__((fallthrough)) but the comment
looks nice and does not need to be ifdef'ed for compatibility.
Reference: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652
Reference: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
Reviewed-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Suggested-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'text-utils/ul.c')
| -rw-r--r-- | text-utils/ul.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/text-utils/ul.c b/text-utils/ul.c index 3986b4206..736483ef4 100644 --- a/text-utils/ul.c +++ b/text-utils/ul.c @@ -208,7 +208,7 @@ int main(int argc, char **argv) default: warnx(_("trouble reading terminfo")); - /* fall through to ... */ + /* fallthrough */ case 0: if (tflag) @@ -317,7 +317,7 @@ static void filter(FILE *f) } obuf[col].c_char = '_'; obuf[col].c_width = 1; - /* fall through */ + /* fallthrough */ case ' ': setcol(col + 1); continue; |