diff options
| author | Sami Kerola | 2012-03-18 21:38:39 +0100 |
|---|---|---|
| committer | Karel Zak | 2012-03-30 16:48:13 +0200 |
| commit | 83134551610941b11081128fcce12ba95ed47964 (patch) | |
| tree | f8e54450e2fe336bdb1fdd1484796f29b6a556b6 /tools | |
| parent | tools: checkconfig.sh: make scripts bourne sh compliant [checkbashisms] (diff) | |
| download | kernel-qcow2-util-linux-83134551610941b11081128fcce12ba95ed47964.tar.gz kernel-qcow2-util-linux-83134551610941b11081128fcce12ba95ed47964.tar.xz kernel-qcow2-util-linux-83134551610941b11081128fcce12ba95ed47964.zip | |
tools: config-gen: make scripts bourne sh compliant [checkbashisms]
$ checkbashisms config-gen
script config-gen does not appear to be a /bin/sh script
possible bashism in config-gen line 27 (export foo=bar should be foo=bar; export foo):
export CFLAGS="$CFLAGS"
$ checkbashisms config-gen-functions.sh
possible bashism in config-gen-functions.sh line 14 ('function' is useless):
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/config-gen | 5 | ||||
| -rw-r--r-- | tools/config-gen-functions.sh | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/tools/config-gen b/tools/config-gen index 441e5a465..720c5a7dd 100755 --- a/tools/config-gen +++ b/tools/config-gen @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # # Copyright (C) 2011 Karel Zak <kzak@redhat.com> # @@ -24,7 +24,8 @@ for x in $opts; do done if [ -n "$CFLAGS" ]; then echo "CFLAGS: $CFLAGS" - export CFLAGS="$CFLAGS" + CFLAGS="$CFLAGS" + export CFLAGS fi echo diff --git a/tools/config-gen-functions.sh b/tools/config-gen-functions.sh index 4f0e575f6..17e5a41e7 100644 --- a/tools/config-gen-functions.sh +++ b/tools/config-gen-functions.sh @@ -11,7 +11,7 @@ # # ul_get_configuration $top_srcdir/tools/config-gen.d/all # -function ul_get_configuration { +ul_get_configuration() { local conf="$1" local dir=$(dirname $1) local opts=$(cat $conf) |