Clean up and modernize code

- static "new-style" signal->slot connections
- Fix a lot of things Clang-Tidy complained about
- Move includes to .cpp files and use forward decls in .h
- Don't use <QtWidgets> and <QtCore>, but specific includes instead

1 files changed, 2 insertions, 7 deletions

diff --git a/src/client/clientapp/clientapp.h b/src/client/clientapp/clientapp.h
index 91dccf3..0824683 100644
--- a/src/client/clientapp/clientapp.h
+++ b/src/client/clientapp/clientapp.h
@@ -9,7 +9,7 @@
 #if defined(clientApp)
 #undef clientApp
 #endif
-#define clientApp (static_cast<ClientApp*>(QCoreApplication::instance()))
+#define clientApp (static_cast<ClientApp*>(QCoreApplication::instance())) // NOLINT(cppcoreguidelines-pro-type-static-cast-downcast)
 
 class Toolbar;
 class ConnectWindow;
@@ -36,12 +36,9 @@ private:
 	ServerConnection* _connection;
 	QStringList _arguments;
 	QString _iniPath;
-	bool _isManagerPc;
 
 	QStringList parseParameters();
 
-	void readIsManagerPc();
-
 public:
 
 	ClientApp(int& argc, char** argv);
@@ -56,9 +53,7 @@ public:
 
 	ConnectWindow* connectWindow() const { return _connectWindow; }
 
-	bool isConfiguredAsManager() { return _isManagerPc; }
-
-	bool isConnectedToLocalManager() { return _connection != nullptr && _connection->isLocalConnection(); }
+	bool isConnectedToLocalManager() const { return _connection != nullptr && _connection->isLocalConnection(); }
 
 private slots: