diff options
| author | AlexChen | 2020-10-30 03:46:55 +0100 |
|---|---|---|
| committer | Jason Wang | 2020-11-11 09:53:01 +0100 |
| commit | d949fe64b074af7adca1076556aaebbcfdf6932e (patch) | |
| tree | 99be52d374c300ebadb25c0d2bffcb3ee5af3bc4 | |
| parent | net: remove an assert call in eth_get_gso_type (diff) | |
| download | qemu-d949fe64b074af7adca1076556aaebbcfdf6932e.tar.gz qemu-d949fe64b074af7adca1076556aaebbcfdf6932e.tar.xz qemu-d949fe64b074af7adca1076556aaebbcfdf6932e.zip | |
net/l2tpv3: Remove redundant check in net_init_l2tpv3()
The result has been checked to be NULL before, it cannot be NULL here,
so the check is redundant. Remove it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| -rw-r--r-- | net/l2tpv3.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 55fea17c0f..e4d4218db6 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -655,9 +655,8 @@ int net_init_l2tpv3(const Netdev *netdev, error_setg(errp, "could not bind socket err=%i", errno); goto outerr; } - if (result) { - freeaddrinfo(result); - } + + freeaddrinfo(result); memset(&hints, 0, sizeof(hints)); @@ -686,9 +685,7 @@ int net_init_l2tpv3(const Netdev *netdev, memcpy(s->dgram_dst, result->ai_addr, result->ai_addrlen); s->dst_size = result->ai_addrlen; - if (result) { - freeaddrinfo(result); - } + freeaddrinfo(result); if (l2tpv3->has_counter && l2tpv3->counter) { s->has_counter = true; |