diff options
| author | Richard Henderson | 2022-04-01 20:46:35 +0200 |
|---|---|---|
| committer | Richard Henderson | 2022-04-27 04:59:51 +0200 |
| commit | 0cbc135917141053c80480fefbe55f70bb3b1562 (patch) | |
| tree | e7e899bc89f1b6d5aee2e412928bcc72a8b239fc /target/i386/tcg | |
| parent | target/s390x: Fix the accumulation of ccm in op_icm (diff) | |
| download | qemu-0cbc135917141053c80480fefbe55f70bb3b1562.tar.gz qemu-0cbc135917141053c80480fefbe55f70bb3b1562.tar.xz qemu-0cbc135917141053c80480fefbe55f70bb3b1562.zip | |
target/i386: Suppress coverity warning on fsave/frstor
Coverity warns that 14 << data32 may overflow with respect
to the target_ulong to which it is subsequently added.
We know this wasn't true because data32 is in [1,2],
but the suggested fix is perfectly fine.
Fixes: Coverity CID 1487135, 1487256
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Message-Id: <20220401184635.327423-1-richard.henderson@linaro.org>
Diffstat (limited to 'target/i386/tcg')
| -rw-r--r-- | target/i386/tcg/fpu_helper.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c index ebf5e73df9..30bc44fcf8 100644 --- a/target/i386/tcg/fpu_helper.c +++ b/target/i386/tcg/fpu_helper.c @@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32, do_fstenv(env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong)14 << data32; for (i = 0; i < 8; i++) { tmp = ST(i); do_fstt(env, tmp, ptr, retaddr); @@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32, int i; do_fldenv(env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong)14 << data32; for (i = 0; i < 8; i++) { tmp = do_fldt(env, ptr, retaddr); |