diff options
| author | Michael Brown | 2014-07-31 13:22:40 +0200 |
|---|---|---|
| committer | Michael Brown | 2014-07-31 13:50:09 +0200 |
| commit | 4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c (patch) | |
| tree | 7d6cc53d78cc711330425810dd78320ab5aaaf81 /src/image | |
| parent | [efi] Allow compiler to perform type checks on EFI_HANDLE (diff) | |
| download | ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.gz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.xz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.zip | |
[efi] Avoid unnecessarily passing pointers to EFI_HANDLEs
efi_file_install() and efi_download_install() are both used to install
onto existing handles. There is therefore no need to allow for each
of their calls to InstallMultipleProtocolInterfaces() to create a new
handle.
By passing the handle directly (rather than a pointer to the handle),
we avoid potential confusion (and erroneous debug message colours).
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/image')
| -rw-r--r-- | src/image/efi_image.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/image/efi_image.c b/src/image/efi_image.c index 02ff8b2f..45a68e53 100644 --- a/src/image/efi_image.c +++ b/src/image/efi_image.c @@ -157,14 +157,14 @@ static int efi_image_exec ( struct image *image ) { } /* Install file I/O protocols */ - if ( ( rc = efi_file_install ( &snpdev->handle ) ) != 0 ) { + if ( ( rc = efi_file_install ( snpdev->handle ) ) != 0 ) { DBGC ( image, "EFIIMAGE %p could not install file protocol: " "%s\n", image, strerror ( rc ) ); goto err_file_install; } /* Install iPXE download protocol */ - if ( ( rc = efi_download_install ( &snpdev->handle ) ) != 0 ) { + if ( ( rc = efi_download_install ( snpdev->handle ) ) != 0 ) { DBGC ( image, "EFIIMAGE %p could not install iPXE download " "protocol: %s\n", image, strerror ( rc ) ); goto err_download_install; |