Fix A LOT of type problems, logic flaws, uninitialized variables etc.

Most of them were found by phpstorm, so I put in some time and
went through the list, fixing quite a bunch of them.

1 files changed, 5 insertions, 0 deletions

diff --git a/install.php b/install.php
index a5d18f0c..88eb82c2 100644
--- a/install.php
+++ b/install.php
@@ -256,6 +256,9 @@ function hasUpdateScript($module)
 	return is_readable($module->getDir() . '/install.inc.php');
 }
 
+/**
+ * @param Module $module
+ */
 function runUpdateScript($module)
 {
 	require_once $module->getDir() . '/install.inc.php';
@@ -277,6 +280,7 @@ if (DIRECT_MODE) {
 			$new[] = $entry;
 		}
 	}
+	/* @var Module[] $new */
 	$modules = $new;
 	if (empty($modules)) {
 		finalResponse(UPDATE_NOOP, 'No modules with install scripts, nothing to do');
@@ -287,6 +291,7 @@ if (DIRECT_MODE) {
 	for ($i = 0; $i < $count; ++$i) {
 		$assoc[$modules[$i]->getIdentifier()] = $modules[($i + 1) % $count];
 	}
+	/* @var Module[] $assoc */
 
 	if (!empty($argv[1])) {
 		$last = $argv[1];