Add function param/return types, fix a lot more phpstorm complaints

5 files changed, 7 insertions, 7 deletions

diff --git a/modules-available/dozmod/pages/actionlog.inc.php b/modules-available/dozmod/pages/actionlog.inc.php
index 0b6feb6f..182198c2 100644
--- a/modules-available/dozmod/pages/actionlog.inc.php
+++ b/modules-available/dozmod/pages/actionlog.inc.php
@@ -92,7 +92,7 @@ class SubPage
 		return $desc;
 	}
 
-	private static function addImageHeader()
+	private static function addImageHeader(): bool
 	{
 		$image = Database::queryFirst('SELECT o.userid AS ouserid, o.firstname AS ofirstname, o.lastname AS olastname,
 				u.userid AS uuserid, u.firstname AS ufirstname, u.lastname AS ulastname,
@@ -114,7 +114,7 @@ class SubPage
 		return $image !== false;
 	}
 
-	private static function addLectureHeader()
+	private static function addLectureHeader(): bool
 	{
 		$lecture = Database::queryFirst('SELECT o.userid AS ouserid, o.firstname AS ofirstname, o.lastname AS olastname,
 				u.userid AS uuserid, u.firstname AS ufirstname, u.lastname AS ulastname,
diff --git a/modules-available/dozmod/pages/expiredimages.inc.php b/modules-available/dozmod/pages/expiredimages.inc.php
index b61b863b..ab563273 100644
--- a/modules-available/dozmod/pages/expiredimages.inc.php
+++ b/modules-available/dozmod/pages/expiredimages.inc.php
@@ -8,7 +8,7 @@ class SubPage
 
 	}
 
-	private static function loadExpiredImages()
+	private static function loadExpiredImages(): array
 	{
 		$res = Database::simpleQuery("SELECT b.displayname,
 			own.firstname, own.lastname, own.userid,
diff --git a/modules-available/dozmod/pages/mailconfig.inc.php b/modules-available/dozmod/pages/mailconfig.inc.php
index 08205f2e..aa03a4d3 100644
--- a/modules-available/dozmod/pages/mailconfig.inc.php
+++ b/modules-available/dozmod/pages/mailconfig.inc.php
@@ -34,7 +34,7 @@ class SubPage
 		Util::redirect('?do=DozMod&section=mailconfig');
 	}
 
-	private static function cleanMailArray()
+	private static function cleanMailArray(): array
 	{
 		$keys = array('host', 'port', 'ssl', 'senderAddress', 'replyTo', 'username', 'password', 'serverName');
 		$data = array();
diff --git a/modules-available/dozmod/pages/templates.inc.php b/modules-available/dozmod/pages/templates.inc.php
index b857115f..b916e14c 100644
--- a/modules-available/dozmod/pages/templates.inc.php
+++ b/modules-available/dozmod/pages/templates.inc.php
@@ -69,7 +69,7 @@ class SubPage
 		]);
 	}
 
-	private static function forcmp($string)
+	private static function forcmp(string $string): string
 	{
 		return trim(str_replace("\r\n", "\n", $string));
 	}
diff --git a/modules-available/dozmod/pages/users.inc.php b/modules-available/dozmod/pages/users.inc.php
index cdf22b9d..fe00a71b 100644
--- a/modules-available/dozmod/pages/users.inc.php
+++ b/modules-available/dozmod/pages/users.inc.php
@@ -64,13 +64,13 @@ class SubPage
 			. ' ORDER BY displayname ASC');
 		$rows = array();
 		foreach ($res as $row) {
-			$row['canlogin'] = self::checked($row['canlogin']);
+			$row['canlogin'] = self::checked((bool)$row['canlogin']);
 			$rows[] = $row;
 		}
 		Render::addTemplate('orglist', array('organizations' => $rows));
 	}
 
-	private static function checked($val)
+	private static function checked(bool $val): string
 	{
 		if ($val)
 			return 'checked="checked"';