[locationinfo] Better backend-specific property handling, get rid of URL

- The backend URL still had special treatment for legacy reasons, when it
  would be perfectly fine to make it just another generic property the
  backend has to define.
- Allow for the backend to declare a default value for properties.
- Base class will now check and sanitize the setCredentials() input.

1 files changed, 8 insertions, 9 deletions

diff --git a/modules-available/locationinfo/inc/coursebackend/coursebackend_dummy.inc.php b/modules-available/locationinfo/inc/coursebackend/coursebackend_dummy.inc.php
index 5bceac3e..b8329196 100644
--- a/modules-available/locationinfo/inc/coursebackend/coursebackend_dummy.inc.php
+++ b/modules-available/locationinfo/inc/coursebackend/coursebackend_dummy.inc.php
@@ -13,7 +13,7 @@ class CourseBackend_Dummy extends CourseBackend
 	 * @param int $serverId ID of the server
 	 * @returns bool if the credentials were in the correct format
 	 */
-	public function setCredentials($json, $location, $serverId)
+	public function setCredentialsInternal($json)
 	{
 		$x = $json;
 		$this->pw = $x['password'];
@@ -47,15 +47,14 @@ class CourseBackend_Dummy extends CourseBackend
 	public function getCredentials()
 	{
 		$options = ["opt1", "opt2", "opt3", "opt4", "opt5", "opt6", "opt7", "opt8"];
-		$credentials = [
-			"username" => "string",
-			"password" => "password",
-			"integer" => "int",
-			"option" => $options,
-			"CheckTheBox" => "bool",
-			"CB2 t" => "bool"
+		return [
+			new BackendProperty('username', 'string', 'default-user'),
+			new BackendProperty('password', 'password'),
+			new BackendProperty('integer', 'int', 7),
+			new BackendProperty('option', $options),
+			new BackendProperty('CheckTheBox', 'bool'),
+			new BackendProperty('CB2t', 'bool', true)
 		];
-		return $credentials;
 	}
 
 	/**