Add function param/return types, fix a lot more phpstorm complaints

3 files changed, 4 insertions, 5 deletions

diff --git a/modules-available/main/hooks/cron.inc.php b/modules-available/main/hooks/cron.inc.php
index 747115c2..5b20b6d0 100644
--- a/modules-available/main/hooks/cron.inc.php
+++ b/modules-available/main/hooks/cron.inc.php
@@ -10,6 +10,8 @@ case 3:
 case 4:
 	Database::exec("DELETE FROM callback WHERE (UNIX_TIMESTAMP() - 86400) > dateline");
 	break;
+default:
+	// Do nothing
 }
 
 Trigger::checkCallbacks();
diff --git a/modules-available/main/hooks/translation.inc.php b/modules-available/main/hooks/translation.inc.php
index 7590dcb6..28247374 100644
--- a/modules-available/main/hooks/translation.inc.php
+++ b/modules-available/main/hooks/translation.inc.php
@@ -18,11 +18,8 @@ $HANDLER['subsections'] = array(
  * Global tags.
  * This just returns the union of global tags of all languages, as there is no
  * way to define a definite set of required global tags.
- *
- * @param Module $module
- * @return array dem tags
  */
-$HANDLER['grep_global-tags'] = function($module) {
+$HANDLER['grep_global-tags'] = function(Module $module): array {
 	$want = array();
 	foreach (Dictionary::getLanguages() as $lang) {
 		$want += Dictionary::getArray($module->getIdentifier(), 'global-tags', $lang);
diff --git a/modules-available/main/page.inc.php b/modules-available/main/page.inc.php
index 016a510d..b0d7d125 100644
--- a/modules-available/main/page.inc.php
+++ b/modules-available/main/page.inc.php
@@ -33,7 +33,7 @@ class Page_Main extends Page
 		}
 
 		// Update warning state
-		Property::setNeedsSetup($needSetup ? 1 : 0);
+		Property::setNeedsSetup($needSetup);
 	}
 
 	protected function doAjax()