Moderize Database handling

* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries

1 files changed, 3 insertions, 3 deletions

diff --git a/modules-available/roomplanner/page.inc.php b/modules-available/roomplanner/page.inc.php
index 8c3beace..a591014b 100644
--- a/modules-available/roomplanner/page.inc.php
+++ b/modules-available/roomplanner/page.inc.php
@@ -195,7 +195,7 @@ class Page_Roomplanner extends Page
 
 			$returnObject = ['machines' => []];
 
-			while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
+			foreach ($result as $row) {
 				if (!Location::isFixedLocationValid($roomLocationId, $row['subnetlocationid']))
 					continue;
 				if (empty($row['hostname'])) {
@@ -393,7 +393,7 @@ class Page_Roomplanner extends Page
 				WHERE fixedlocationid = :locationid',
 			['locationid' => $this->locationid]);
 		$machines = [];
-		while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($result as $row) {
 			$machine = [];
 			$pos = json_decode($row['position'], true);
 			if ($pos === false || !isset($pos['gridRow']) || !isset($pos['gridCol'])) {
@@ -429,7 +429,7 @@ class Page_Roomplanner extends Page
 
 		$machines = [];
 
-		while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($result as $row) {
 			if (empty($row['hostname'])) {
 				$row['hostname'] = $row['clientip'];
 			}