summaryrefslogtreecommitdiffstats
path: root/modules-available/roomplanner
diff options
context:
space:
mode:
authorSimon Rettberg2023-11-02 19:08:58 +0100
committerSimon Rettberg2023-11-02 19:08:58 +0100
commitc2d95ffaeaa289752b4c7b6664b6ca112a02e350 (patch)
tree2c29b0157d14198aadbdbc9f8c18ded0bd4dadcd /modules-available/roomplanner
parent[rebootcontrol] Remove API prototype (diff)
downloadslx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.gz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.xz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.zip
Roundup of issues reported by PHPStorm
Mostly redundant checks, logic errors, dead code, etc.
Diffstat (limited to 'modules-available/roomplanner')
-rw-r--r--modules-available/roomplanner/page.inc.php6
1 files changed, 2 insertions, 4 deletions
diff --git a/modules-available/roomplanner/page.inc.php b/modules-available/roomplanner/page.inc.php
index 9f890518..7ac6890d 100644
--- a/modules-available/roomplanner/page.inc.php
+++ b/modules-available/roomplanner/page.inc.php
@@ -361,10 +361,8 @@ class Page_Roomplanner extends Page
'tutoruuid' => $tutorUuid
]);
// See if the client is known, set run-mode
- if (empty($managerIp)) {
- RunMode::deleteMode(Page::getModule(), $this->locationid);
- } else {
- RunMode::deleteMode(Page::getModule(), $this->locationid);
+ RunMode::deleteMode(Page::getModule(), $this->locationid);
+ if (!empty($managerIp)) {
$pc = Statistics::getMachinesByIp($managerIp, Machine::NO_DATA, 'lastseen DESC');
if (!empty($pc)) {
$dedicated = (Request::post('dedimgr') === 'on');