Fix more type errors, stricter typing

2 files changed, 10 insertions, 3 deletions

diff --git a/modules-available/statistics/inc/statistics.inc.php b/modules-available/statistics/inc/statistics.inc.php
index 2a9ca3c9..c12f5be4 100644
--- a/modules-available/statistics/inc/statistics.inc.php
+++ b/modules-available/statistics/inc/statistics.inc.php
@@ -46,11 +46,11 @@ class Statistics
 	 * @param string $sort something like 'lastseen ASC' - not sanitized, don't pass user input!
 	 * @return Machine[] list of matches
 	 */
-	public static function getMachinesByIp(string $ip, int $returnData, bool $sort = false): array
+	public static function getMachinesByIp(string $ip, int $returnData, string $sort = null): array
 	{
 		$fields = self::initFields($returnData);
 
-		if ($sort === false) {
+		if ($sort === null) {
 			$sort = '';
 		} else {
 			$sort = "ORDER BY $sort";
diff --git a/modules-available/statistics/inc/statisticshooks.inc.php b/modules-available/statistics/inc/statisticshooks.inc.php
index b17cf4a9..405ed5f7 100644
--- a/modules-available/statistics/inc/statisticshooks.inc.php
+++ b/modules-available/statistics/inc/statisticshooks.inc.php
@@ -13,7 +13,11 @@ class StatisticsHooks
 			['machineuuid' => $machineuuid]);
 	}
 
-	public static function getBaseconfigName(string $machineuuid): string
+	/**
+	 * Hook for baseconfig.
+	 * @return false|string Client name, or false if invalid
+	 */
+	public static function getBaseconfigName(string $machineuuid)
 	{
 		self::getRow($machineuuid);
 		if (self::$row === false)
@@ -21,6 +25,9 @@ class StatisticsHooks
 		return self::$row['hostname'] ?: self::$row['clientip'];
 	}
 
+	/**
+	 * Hook for baseconfig.
+	 */
 	public static function baseconfigLocationResolver(string $machineuuid): int
 	{
 		self::getRow($machineuuid);