Roundup of issues reported by PHPStorm

Mostly redundant checks, logic errors, dead code, etc.

1 files changed, 5 insertions, 6 deletions

diff --git a/modules-available/sysconfig/addmodule_screensaver.inc.php b/modules-available/sysconfig/addmodule_screensaver.inc.php
index 9641bab3..24dfadd0 100644
--- a/modules-available/sysconfig/addmodule_screensaver.inc.php
+++ b/modules-available/sysconfig/addmodule_screensaver.inc.php
@@ -67,18 +67,17 @@ class Screensaver_Start extends AddModule_Base
 class Screensaver_Text extends AddModule_Base
 {
 	private $session_data;
-	private $id;
 
 	protected function preprocessInternal()
 	{
 		/* Load session data */
 		$this->session_data = Session::get('data');
-		$this->id = Request::post('id', '', 'string');
+		$id = Request::post('id', '', 'string');
 
-		if ($this->id === 'start') {
+		if ($id === 'start') {
 			Screensaver_Helper::processQssData($this->session_data);
-		} elseif ($this->id !== '') {
-			Screensaver_Helper::processScreensaverText($this->session_data, $this->id);
+		} elseif ($id !== '') {
+			Screensaver_Helper::processScreensaverText($this->session_data, $id);
 		}
 
 		$next = Request::post('next', $this->session_data['next'], 'string');
@@ -116,7 +115,7 @@ class Screensaver_Text extends AddModule_Base
 		 * Dictionary::translate('saver_DescriptionShutdown');
 		 */
 		$data['title'] = Dictionary::translate('saver_Title' . $tag, true);
-		$data['description'] = Dictionary::translate('saver_Description' . $tag, true);;
+		$data['description'] = Dictionary::translate('saver_Description' . $tag, true);
 		$data['msg_value'] = $this->session_data['messages']['General'][$next];
 		$data['msg_locked_value'] = $this->session_data['messages']['General'][$next . '-locked'];
 		$data['text_value'] = $this->session_data['texts']['text-' . $next];