[syslog] Improve POSTs for audit logging

1 files changed, 25 insertions, 21 deletions

diff --git a/modules-available/syslog/page.inc.php b/modules-available/syslog/page.inc.php
index bbc12e92..632e5e3f 100644
--- a/modules-available/syslog/page.inc.php
+++ b/modules-available/syslog/page.inc.php
@@ -14,31 +14,35 @@ class Page_SysLog extends Page
 			Message::addError('main.no-permission');
 			Util::redirect('?do=Main');
 		}
-
-		if (($days = Request::post('anondays', false, 'int')) !== false) {
-			User::assertPermission('configure-anonymization', NULL,'?do=syslog');
-			if ($days < 0 || $days > 366) {
-				Audit::overrideResponseCode(400);
-				Message::addError('anon-days-out-of-range', $days);
-			} else {
-				Property::set(self::PROP_ANON_DAYS, $days);
-				Message::addSuccess('anon-days-saved');
+		$action = Request::post('action', null, 'string');
+		if ($action !== null) {
+			if ($action === 'anondays') {
+				User::assertPermission('configure-anonymization', NULL,'?do=syslog');
+				$days = Request::post('anondays', 0, 'int');
+				if ($days < 0 || $days > 366) {
+					Audit::overrideResponseCode(400);
+					Message::addError('anon-days-out-of-range', $days);
+				} else {
+					Property::set(self::PROP_ANON_DAYS, $days);
+					Message::addSuccess('anon-days-saved');
+				}
+				Util::redirect('?do=syslog', 200);
 			}
-			Util::redirect('?do=syslog');
-		}
-		if (Request::isPost()) {
-			$pairs = [];
-			foreach (['search', 'filter', 'not', 'machineuuid'] as $key) {
-				$val = Request::any($key, false, 'string');
-				if (!empty($val)) {
-					if ($key === 'not') {
-						$val = (bool)$val;
+
+			if ($action === 'filter') {
+				$pairs = [];
+				foreach (['search', 'filter', 'not', 'machineuuid'] as $key) {
+					$val = Request::any($key, false, 'string');
+					if (!empty($val)) {
+						if ($key === 'not') {
+							$val = (bool)$val;
+						}
+						$pairs[$key] = $val;
 					}
-					$pairs[$key] = $val;
+					Session::set('log_' . $key, $pairs[$key] ?? false, false);
 				}
-				Session::set('log_' . $key, $pairs[$key] ?? false, false);
+				Util::redirect('?do=syslog&' . http_build_query($pairs), 200);
 			}
-			Util::redirect('?do=syslog&' . http_build_query($pairs));
 		}
 		User::assertPermission('*');
 	}