summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorSimon Rettberg2017-12-16 18:33:16 +0100
committerSimon Rettberg2017-12-16 18:33:16 +0100
commitcd55ead3e2810e209b726faca12fa749f6875d0f (patch)
tree94b2f29b023e8a0c5100e1d06c974c3c04f890fd /tools
parentMerge branch 'permission-manager' of openslx.org:openslx-ng/slx-admin into pe... (diff)
downloadslx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.tar.gz
slx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.tar.xz
slx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.zip
Fix A LOT of type problems, logic flaws, uninitialized variables etc.
Most of them were found by phpstorm, so I put in some time and went through the list, fixing quite a bunch of them.
Diffstat (limited to 'tools')
-rw-r--r--tools/convert-modules.php4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/convert-modules.php b/tools/convert-modules.php
index 9b479886..f8c7a1a5 100644
--- a/tools/convert-modules.php
+++ b/tools/convert-modules.php
@@ -182,8 +182,8 @@ foreach ($messages as $id => $modules) {
asort($modules, SORT_NUMERIC);
$modules = array_reverse($modules, true);
reset($modules);
- list($topModule, $topCount) = each($modules);
- reset($modules);
+ $topModule = key($modules);
+ $topCount = $modules[$topModule];
$sum = 0;
foreach ($modules as $c) {
$sum += $c;