summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorSimon Rettberg2023-11-02 19:08:58 +0100
committerSimon Rettberg2023-11-02 19:08:58 +0100
commitc2d95ffaeaa289752b4c7b6664b6ca112a02e350 (patch)
tree2c29b0157d14198aadbdbc9f8c18ded0bd4dadcd /tools
parent[rebootcontrol] Remove API prototype (diff)
downloadslx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.gz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.xz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.zip
Roundup of issues reported by PHPStorm
Mostly redundant checks, logic errors, dead code, etc.
Diffstat (limited to 'tools')
-rw-r--r--tools/convert-modules.php1
-rw-r--r--tools/global-candidates.php1
2 files changed, 1 insertions, 1 deletions
diff --git a/tools/convert-modules.php b/tools/convert-modules.php
index f8c7a1a5..aa43d951 100644
--- a/tools/convert-modules.php
+++ b/tools/convert-modules.php
@@ -181,7 +181,6 @@ echo "Processing\n";
foreach ($messages as $id => $modules) {
asort($modules, SORT_NUMERIC);
$modules = array_reverse($modules, true);
- reset($modules);
$topModule = key($modules);
$topCount = $modules[$topModule];
$sum = 0;
diff --git a/tools/global-candidates.php b/tools/global-candidates.php
index 12e900a5..c42a43aa 100644
--- a/tools/global-candidates.php
+++ b/tools/global-candidates.php
@@ -58,6 +58,7 @@ foreach ($tags as $k => &$tag) {
}
}
}
+unset($tag);
echo "\n\nDUPLICATE STRINGS WITH DIFFERENT NAMES:\n";
foreach ($strings as $text => $data) {