summaryrefslogtreecommitdiffstats
path: root/modules-available/adduser/page.inc.php
diff options
context:
space:
mode:
Diffstat (limited to 'modules-available/adduser/page.inc.php')
-rw-r--r--modules-available/adduser/page.inc.php9
1 files changed, 3 insertions, 6 deletions
diff --git a/modules-available/adduser/page.inc.php b/modules-available/adduser/page.inc.php
index 4ab69919..0ef28a3e 100644
--- a/modules-available/adduser/page.inc.php
+++ b/modules-available/adduser/page.inc.php
@@ -32,10 +32,8 @@ class Page_AddUser extends Page
$email = Request::post('email', '', 'string');
if (empty($login) || empty($pass1) || empty($pass2) || empty($fullname)) {
Message::addError('main.empty-field');
- return;
} elseif ($pass1 !== $pass2) {
Message::addError('password-mismatch');
- return;
} else {
if (Database::queryFirst('SELECT userid FROM user LIMIT 1') !== false) {
User::assertPermission('user.add');
@@ -69,7 +67,6 @@ class Page_AddUser extends Page
}
Message::addInfo('adduser-success');
$this->saveRoles($id);
- return;
}
}
@@ -203,7 +200,7 @@ class Page_AddUser extends Page
} elseif ($show === 'list') {
User::assertPermission('user.view-list');
$page = new Paginate('SELECT userid, login, fullname, phone, email FROM user ORDER BY login', 50);
- $data = ['list' => $page->exec()->fetchAll(PDO::FETCH_ASSOC)];
+ $data = ['list' => $page->exec()->fetchAll()];
foreach ($data['list'] as &$u) {
// Don't allow deleting user 1 and self
$u['hide_delete'] = $u['userid'] == 1 || $u['userid'] == User::getId();
@@ -218,13 +215,13 @@ class Page_AddUser extends Page
}
}
- private function showRoles($userid = false)
+ private function showRoles(int $userid = null): void
{
if (!Module::isAvailable('permissionmanager'))
return;
if (!User::hasPermission('.permissionmanager.users.edit-roles'))
return;
- $data = ['roles' => PermissionUtil::getRoles($userid, false)];
+ $data = ['roles' => PermissionUtil::getRoles($userid)];
Render::addTemplate('user-permissions', $data);
}