diff options
Diffstat (limited to 'modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php')
| -rw-r--r-- | modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php b/modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php index 3a82b4f7..a2b25f55 100644 --- a/modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php +++ b/modules-available/serversetup-bwlp-ipxe/inc/ipxebuilder.inc.php @@ -13,10 +13,9 @@ class IPxeBuilder * Checkout given commit/ref of ipxe repo. Returns the according task-id, or null on error * * @param string $version version ref (commit, tag, ...) - * @param string|null $parent parent task id - * @return ?string + * @param ?string $parent parent task id, if any */ - public static function setIpxeVersion($version, $parent = null) + public static function setIpxeVersion(string $version, ?string $parent = null): ?string { $task = Taskmanager::submit('IpxeVersion', [ 'action' => 'CHECKOUT', @@ -30,10 +29,7 @@ class IPxeBuilder return $task['id']; } - /** - * @return array|false - */ - public static function getVersionTaskResult() + public static function getVersionTaskResult(): ?array { $task = Taskmanager::status(IPxeBuilder::VERSION_LIST_TASK); if (!Taskmanager::isTask($task) || Taskmanager::isFailed($task)) { @@ -44,13 +40,13 @@ class IPxeBuilder if (Taskmanager::isFinished($task) && !Taskmanager::isFailed($task)) { return $task['data']; } - return false; + return null; } /** * Callback when compile Taskmanager job finished */ - public static function compileCompleteCallback($task) + public static function compileCompleteCallback(array $task): void { if (!Taskmanager::isFinished($task) || Taskmanager::isFailed($task)) return; @@ -75,7 +71,7 @@ class IPxeBuilder Property::set(IPxeBuilder::PROP_IPXE_BUILDSTRING, $buildString); } - public static function setIPxeVersionCallback($task) + public static function setIPxeVersionCallback(array $task): void { if (!Taskmanager::isFinished($task) || Taskmanager::isFailed($task) || empty($task['data']['ref'])) return; |