summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Rettberg2020-09-28 12:02:54 +0200
committerSimon Rettberg2020-09-28 12:02:54 +0200
commit5e143d493eb088e3f5dce86e8906483e7efc909d (patch)
treea9f6e4db8620cce8cbcc5f9eda99fd21febedd4d
parent[server] Remove unused exception (diff)
downloadtutor-module-5e143d493eb088e3f5dce86e8906483e7efc909d.tar.gz
tutor-module-5e143d493eb088e3f5dce86e8906483e7efc909d.tar.xz
tutor-module-5e143d493eb088e3f5dce86e8906483e7efc909d.zip
[server] Abort orphan scan/delete if known image list is empty
On the off-chance that something goes wron when querying, or the database got emptied, don't just blindly wipe the whole vmstore. It's probably smarter to restore a backup first, or if you really mean to start afresh, just empty the vmstore manually, or just upload one VM and then use this feature again.
-rw-r--r--dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java
index 2709e567..1d5b27e7 100644
--- a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java
+++ b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java
@@ -85,6 +85,9 @@ public class WebRpc {
} catch (SQLException e1) {
return WebServer.internalServerError("Cannot query list of known images from database");
}
+ if (known.isEmpty()) {
+ return WebServer.internalServerError("SAFTY CHECK: Known image list empty, aborting");
+ }
try {
// Consider only regular files, call checkFile for each one
Files.find(Configuration.getVmStoreProdPath().toPath(), 8,