diff options
| author | Jan Kiszka | 2009-07-01 20:52:03 +0200 |
|---|---|---|
| committer | Avi Kivity | 2009-09-10 07:33:09 +0200 |
| commit | dc7e795e3dd2a763e5ceaa1615f307e808cf3932 (patch) | |
| tree | 63902e12c372d61e9b15121accce70334c12fd46 | |
| parent | KVM: handle AMD microcode MSR (diff) | |
| download | kernel-qcow2-linux-dc7e795e3dd2a763e5ceaa1615f307e808cf3932.tar.gz kernel-qcow2-linux-dc7e795e3dd2a763e5ceaa1615f307e808cf3932.tar.xz kernel-qcow2-linux-dc7e795e3dd2a763e5ceaa1615f307e808cf3932.zip | |
Revert "KVM: x86: check for cr3 validity in ioctl_set_sregs"
This reverts commit 6c20e1442bb1c62914bb85b7f4a38973d2a423ba.
To my understanding, it became obsolete with the advent of the more
robust check in mmu_alloc_roots (89da4ff17f). Moreover, it prevents
the conceptually safe pattern
1. set sregs
2. register mem-slots
3. run vcpu
by setting a sticky triple fault during step 1.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
| -rw-r--r-- | arch/x86/kvm/x86.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6dde99ca743e..0e74d98641a0 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -4326,13 +4326,7 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, vcpu->arch.cr2 = sregs->cr2; mmu_reset_needed |= vcpu->arch.cr3 != sregs->cr3; - - down_read(&vcpu->kvm->slots_lock); - if (gfn_to_memslot(vcpu->kvm, sregs->cr3 >> PAGE_SHIFT)) - vcpu->arch.cr3 = sregs->cr3; - else - set_bit(KVM_REQ_TRIPLE_FAULT, &vcpu->requests); - up_read(&vcpu->kvm->slots_lock); + vcpu->arch.cr3 = sregs->cr3; kvm_set_cr8(vcpu, sregs->cr8); |