diff options
| author | David Kershner | 2017-03-28 15:34:24 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2017-03-29 09:17:02 +0200 |
| commit | 0b01c6ce5a69b7fffd08281422f4aff6df7f55ff (patch) | |
| tree | dc3f233371aaf12b777c8db1deb7dabe12b0ed11 /drivers/staging/unisys/visorbus/visorchipset.c | |
| parent | staging: unisys: visorbus: add error handling to toolaction_show (diff) | |
| download | kernel-qcow2-linux-0b01c6ce5a69b7fffd08281422f4aff6df7f55ff.tar.gz kernel-qcow2-linux-0b01c6ce5a69b7fffd08281422f4aff6df7f55ff.tar.xz kernel-qcow2-linux-0b01c6ce5a69b7fffd08281422f4aff6df7f55ff.zip | |
staging: unisys: visorbus: add error handling to boottotool_show
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/unisys/visorbus/visorchipset.c')
| -rw-r--r-- | drivers/staging/unisys/visorbus/visorchipset.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 543218f11e0a..00fd02f5a71f 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -130,11 +130,16 @@ static ssize_t boottotool_show(struct device *dev, char *buf) { struct efi_spar_indication efi_spar_indication; + int err; - visorchannel_read(chipset_dev->controlvm_channel, - offsetof(struct spar_controlvm_channel_protocol, - efi_spar_ind), &efi_spar_indication, - sizeof(struct efi_spar_indication)); + err = visorchannel_read(chipset_dev->controlvm_channel, + offsetof(struct spar_controlvm_channel_protocol, + efi_spar_ind), + &efi_spar_indication, + sizeof(struct efi_spar_indication)); + + if (err) + return err; return sprintf(buf, "%u\n", efi_spar_indication.boot_to_tool); } |