diff options
| author | Yuriy M. Kaminskiy | 2016-02-27 17:27:29 +0100 |
|---|---|---|
| committer | Karel Zak | 2016-03-07 15:11:06 +0100 |
| commit | 06fa5817489adb9728f8a29d4cb7602fb48b8bdb (patch) | |
| tree | b3a6f1d0db6b1a6d0e340c1297f243c07c1de618 /disk-utils/fsck.c | |
| parent | lsns.c: fix error return (diff) | |
| download | kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.tar.gz kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.tar.xz kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.zip | |
misc: safer (and uniform) handling of return value
When `rc` is `INT_MAX`, `rc + 1` result in signed integer overflow.
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'disk-utils/fsck.c')
| -rw-r--r-- | disk-utils/fsck.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c index b4630c541..6f9e78b34 100644 --- a/disk-utils/fsck.c +++ b/disk-utils/fsck.c @@ -316,7 +316,7 @@ static int is_irrotational_disk(dev_t disk) "/sys/dev/block/%d:%d/queue/rotational", major(disk), minor(disk)); - if (rc < 0 || (unsigned int) (rc + 1) > sizeof(path)) + if (rc < 0 || (unsigned int) rc >= sizeof(path)) return 0; f = fopen(path, "r"); |