diff options
| author | Sami Kerola | 2019-05-18 22:46:08 +0200 |
|---|---|---|
| committer | Sami Kerola | 2019-05-18 23:07:20 +0200 |
| commit | 84f46d1f6725980697e5a442b06ececd9ceb6576 (patch) | |
| tree | c6913c65d71c27702250d1d8af57390dd2f1642b /disk-utils | |
| parent | Merge branch 'lscpu-output-fix' of https://github.com/kerolasa/util-linux (diff) | |
| download | kernel-qcow2-util-linux-84f46d1f6725980697e5a442b06ececd9ceb6576.tar.gz kernel-qcow2-util-linux-84f46d1f6725980697e5a442b06ececd9ceb6576.tar.xz kernel-qcow2-util-linux-84f46d1f6725980697e5a442b06ececd9ceb6576.zip | |
sfdisk: remove unnecessary size check [cppcheck]
Following warning is false positive. Size of the buffer is defined using
BUFSIZ, and so the strncpy() will never overwrite the last byte that is
initialized to zero in get_user_reply().
[disk-utils/sfdisk.c:137] -> [disk-utils/sfdisk.c:136]: (warning) Either the
condition 'bufsz!=0' is redundant or strncpy() argument nr 3 can have
invalid value. The value is -1 but the valid values are '0:'.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'disk-utils')
| -rw-r--r-- | disk-utils/sfdisk.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c index 4a9640d0e..83f3cf8f7 100644 --- a/disk-utils/sfdisk.c +++ b/disk-utils/sfdisk.c @@ -134,8 +134,6 @@ static int get_user_reply(const char *prompt, char *buf, size_t bufsz) if (!p) return 1; strncpy(buf, p, bufsz - 1); - if (bufsz != 0) - buf[bufsz - 1] = '\0'; free(p); } else #endif |