diff options
| author | Sami Kerola | 2014-09-06 00:17:19 +0200 |
|---|---|---|
| committer | Sami Kerola | 2014-09-19 20:31:12 +0200 |
| commit | 0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce (patch) | |
| tree | 62451bd1c7ee0b768e792c548c0f9d0364be8b49 /sys-utils/renice.c | |
| parent | rename: use usage and version print out macros (diff) | |
| download | kernel-qcow2-util-linux-0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce.tar.gz kernel-qcow2-util-linux-0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce.tar.xz kernel-qcow2-util-linux-0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce.zip | |
renice: disallow --priority <arg> without pid argument
Earlier a lonely priority with an argument but without pid resulted to no
action and success, when the invocation should have failed.
$ renice --priority 42 ; echo $?
0
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'sys-utils/renice.c')
| -rw-r--r-- | sys-utils/renice.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys-utils/renice.c b/sys-utils/renice.c index 06056802b..2075d4076 100644 --- a/sys-utils/renice.c +++ b/sys-utils/renice.c @@ -131,14 +131,14 @@ main(int argc, char **argv) } } - if (argc < 2) - usage(stderr); - - if (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0) { + if (*argv && (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0)) { argc--; argv++; } + if (argc < 2) + usage(stderr); + prio = strtol(*argv, &endptr, 10); if (*endptr) usage(stderr); |