diff options
author | Sami Kerola | 2012-03-18 21:45:11 +0100 |
---|---|---|
committer | Karel Zak | 2012-03-30 16:48:13 +0200 |
commit | 7e08b7d3ce4acbaf64425c9fe6c2836a6921402a (patch) | |
tree | f597b678cff95a6c9b4fb27dbd62673108b8f1b8 /tools | |
parent | tools: config-gen: make scripts bourne sh compliant [checkbashisms] (diff) | |
download | kernel-qcow2-util-linux-7e08b7d3ce4acbaf64425c9fe6c2836a6921402a.tar.gz kernel-qcow2-util-linux-7e08b7d3ce4acbaf64425c9fe6c2836a6921402a.tar.xz kernel-qcow2-util-linux-7e08b7d3ce4acbaf64425c9fe6c2836a6921402a.zip |
tools: ko-release: make scripts bourne sh compliant [checkbashisms]
$ checkbashisms ko-release-gen
possible bashism in ko-release-gen line 31 ('function' is useless):
function die {
possible bashism in ko-release-gen line 36 ('function' is useless):
function add_file {
possible bashism in ko-release-gen line 68 ('function' is useless):
function add_html_dir {
possible bashism in ko-release-gen line 72 (brace expansion):
for fl in $(ls $src/*.{html,css,png}); do
$ checkbashisms ko-release-push
possible bashism in ko-release-push line 29 ('function' is useless):
function die {
possible bashism in ko-release-push line 34 ('function' is useless):
function push_file {
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'tools')
-rwxr-xr-x | tools/ko-release-gen | 8 | ||||
-rwxr-xr-x | tools/ko-release-push | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/tools/ko-release-gen b/tools/ko-release-gen index 58f05415d..9c2b5b471 100755 --- a/tools/ko-release-gen +++ b/tools/ko-release-gen @@ -29,12 +29,12 @@ DISTDIR=${1:-"kernel.org"}/v${VERSION_MAJOR} GPG_CMD="gpg --use-agent --armor --detach-sign --quiet" -function die { +die() { echo $1 exit 1 } -function add_file { +add_file() { local src="$1" local name=$(basename $1) local subdir=$DISTDIR/${2:-""} @@ -66,11 +66,11 @@ function add_file { echo " OK " } -function add_html_dir { +add_html_dir() { local src="$1" # source dir local tgt="$2" # target dir - for fl in $(ls $src/*.{html,css,png}); do + for fl in $(ls $src/*.html $src/*.css $src/*.png); do add_file $fl $tgt done } diff --git a/tools/ko-release-push b/tools/ko-release-push index f08954fc1..ef16fce97 100755 --- a/tools/ko-release-push +++ b/tools/ko-release-push @@ -26,7 +26,7 @@ DISTDIR="${BASEDIR}/v${VERSION_MAJOR}" KO_DIR="/pub/linux/utils/util-linux/v${VERSION_MAJOR}" -function die { +die() { echo $1 exit 1 } |