summaryrefslogtreecommitdiffstats
path: root/modules-available/adduser/page.inc.php
diff options
context:
space:
mode:
authorSimon Rettberg2023-11-02 19:08:58 +0100
committerSimon Rettberg2023-11-02 19:08:58 +0100
commitc2d95ffaeaa289752b4c7b6664b6ca112a02e350 (patch)
tree2c29b0157d14198aadbdbc9f8c18ded0bd4dadcd /modules-available/adduser/page.inc.php
parent[rebootcontrol] Remove API prototype (diff)
downloadslx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.gz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.tar.xz
slx-admin-c2d95ffaeaa289752b4c7b6664b6ca112a02e350.zip
Roundup of issues reported by PHPStorm
Mostly redundant checks, logic errors, dead code, etc.
Diffstat (limited to 'modules-available/adduser/page.inc.php')
-rw-r--r--modules-available/adduser/page.inc.php3
1 files changed, 0 insertions, 3 deletions
diff --git a/modules-available/adduser/page.inc.php b/modules-available/adduser/page.inc.php
index e81e9fb2..499436ff 100644
--- a/modules-available/adduser/page.inc.php
+++ b/modules-available/adduser/page.inc.php
@@ -32,10 +32,8 @@ class Page_AddUser extends Page
$email = Request::post('email', '', 'string');
if (empty($login) || empty($pass1) || empty($pass2) || empty($fullname)) {
Message::addError('main.empty-field');
- return;
} elseif ($pass1 !== $pass2) {
Message::addError('password-mismatch');
- return;
} else {
if (Database::queryFirst('SELECT userid FROM user LIMIT 1') !== false) {
User::assertPermission('user.add');
@@ -69,7 +67,6 @@ class Page_AddUser extends Page
}
Message::addInfo('adduser-success');
$this->saveRoles($id);
- return;
}
}